-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.x] Fix missing composer binary (starter kits couldn't be installed) #9950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
changed the title
[4.x] Fix installing starter kits
[4.x] Fix missing composer binary (starter kits couldn't be installed)
Apr 23, 2024
Bug still exists on Windows 11: #9952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue when installing starter kits, where Statamic was unable to find the Composer binary which caused starter kit installs to fail.
Previously, we were requiring
composer/composer
in ourcomposer.json
, however, we removed this dependency yesterday in #9947 since it wasn't really needed anymore and was causing issues.However, in removing the dependency, the
composer
binary is no longer in thevendor/bin
directory, so we need to use the globally installed Composer binary instead.Related: #9947
Fixes statamic/cli#70